Messages in this thread | | | Date | Fri, 25 Feb 2022 10:55:19 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v6 2/2] Input: add Imagis touchscreen driver |
| |
Hi Markuss,
url: https://github.com/0day-ci/linux/commits/Markuss-Broks/Add-support-for-Imagis-touchscreens/20220223-043645 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: microblaze-randconfig-m031-20220224 (https://download.01.org/0day-ci/archive/20220225/202202250109.qr1l07ts-lkp@intel.com/config) compiler: microblaze-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings: drivers/input/touchscreen/imagis.c:305 imagis_suspend() error: uninitialized symbol 'ret'. drivers/input/touchscreen/imagis.c:321 imagis_resume() error: uninitialized symbol 'ret'.
vim +/ret +305 drivers/input/touchscreen/imagis.c
bc77ee5e0d7309 Markuss Broks 2022-02-22 292 static int __maybe_unused imagis_suspend(struct device *dev) bc77ee5e0d7309 Markuss Broks 2022-02-22 293 { bc77ee5e0d7309 Markuss Broks 2022-02-22 294 struct i2c_client *client = to_i2c_client(dev); bc77ee5e0d7309 Markuss Broks 2022-02-22 295 struct imagis_ts *ts = i2c_get_clientdata(client); bc77ee5e0d7309 Markuss Broks 2022-02-22 296 int ret; bc77ee5e0d7309 Markuss Broks 2022-02-22 297 bc77ee5e0d7309 Markuss Broks 2022-02-22 298 mutex_lock(&ts->input_dev->mutex); bc77ee5e0d7309 Markuss Broks 2022-02-22 299 bc77ee5e0d7309 Markuss Broks 2022-02-22 300 if (input_device_enabled(ts->input_dev)) bc77ee5e0d7309 Markuss Broks 2022-02-22 301 ret = imagis_stop(ts);
"ret" not initialized on else path.
bc77ee5e0d7309 Markuss Broks 2022-02-22 302 bc77ee5e0d7309 Markuss Broks 2022-02-22 303 mutex_unlock(&ts->input_dev->mutex); bc77ee5e0d7309 Markuss Broks 2022-02-22 304 bc77ee5e0d7309 Markuss Broks 2022-02-22 @305 return ret; bc77ee5e0d7309 Markuss Broks 2022-02-22 306 } bc77ee5e0d7309 Markuss Broks 2022-02-22 307 bc77ee5e0d7309 Markuss Broks 2022-02-22 308 static int __maybe_unused imagis_resume(struct device *dev) bc77ee5e0d7309 Markuss Broks 2022-02-22 309 { bc77ee5e0d7309 Markuss Broks 2022-02-22 310 struct i2c_client *client = to_i2c_client(dev); bc77ee5e0d7309 Markuss Broks 2022-02-22 311 struct imagis_ts *ts = i2c_get_clientdata(client); bc77ee5e0d7309 Markuss Broks 2022-02-22 312 int ret; bc77ee5e0d7309 Markuss Broks 2022-02-22 313 bc77ee5e0d7309 Markuss Broks 2022-02-22 314 mutex_lock(&ts->input_dev->mutex); bc77ee5e0d7309 Markuss Broks 2022-02-22 315 bc77ee5e0d7309 Markuss Broks 2022-02-22 316 if (input_device_enabled(ts->input_dev)) bc77ee5e0d7309 Markuss Broks 2022-02-22 317 ret = imagis_start(ts);
same.
bc77ee5e0d7309 Markuss Broks 2022-02-22 318 bc77ee5e0d7309 Markuss Broks 2022-02-22 319 mutex_unlock(&ts->input_dev->mutex); bc77ee5e0d7309 Markuss Broks 2022-02-22 320 bc77ee5e0d7309 Markuss Broks 2022-02-22 @321 return ret; bc77ee5e0d7309 Markuss Broks 2022-02-22 322 }
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
| |