Messages in this thread | | | Date | Wed, 23 Feb 2022 18:05:51 +0100 | From | Jacopo Mondi <> | Subject | Re: [PATCH v5 02/13] media: atmel: atmel-isc-base: replace is_streaming call in s_fmt_vid_cap |
| |
Hi Eugen
On Thu, Feb 17, 2022 at 03:56:34PM +0200, Eugen Hristev wrote: > In s_fmt_vid_cap, we should check if vb2_is_busy and return EBUSY, > not check if it's streaming to return the busy state. > > Suggested-by: Hans Verkuil <hverkuil@xs4all.nl> > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Thanks j
> --- > drivers/media/platform/atmel/atmel-isc-base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c > index d2cc6c99984f..67b4a2323fed 100644 > --- a/drivers/media/platform/atmel/atmel-isc-base.c > +++ b/drivers/media/platform/atmel/atmel-isc-base.c > @@ -1029,7 +1029,7 @@ static int isc_s_fmt_vid_cap(struct file *file, void *priv, > { > struct isc_device *isc = video_drvdata(file); > > - if (vb2_is_streaming(&isc->vb2_vidq)) > + if (vb2_is_busy(&isc->vb2_vidq)) > return -EBUSY; > > return isc_set_fmt(isc, f); > -- > 2.25.1 >
| |