Messages in this thread | | | From | Krishna Yarlagadda <> | Subject | RE: [PATCH v2 5/5] spi: tegra210-quad: combined sequence mode | Date | Wed, 23 Feb 2022 06:34:44 +0000 |
| |
> -----Original Message----- > From: Mark Brown <broonie@kernel.org> > Sent: 23 February 2022 00:12 > To: Krishna Yarlagadda <kyarlagadda@nvidia.com> > Cc: thierry.reding@gmail.com; Jonathan Hunter > <jonathanh@nvidia.com>; linux-spi@vger.kernel.org; linux- > tegra@vger.kernel.org; Sowjanya Komatineni > <skomatineni@nvidia.com>; Laxman Dewangan > <ldewangan@nvidia.com>; robh+dt@kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > p.zabel@pengutronix.de > Subject: Re: [PATCH v2 5/5] spi: tegra210-quad: combined sequence > mode > > On Tue, Feb 22, 2022 at 11:26:11PM +0530, Krishna Yarlagadda wrote: > > > + val = tegra_qspi_readl(tqspi, QSPI_GLOBAL_CONFIG); > > + val |= QSPI_CMB_SEQ_EN; > > + tegra_qspi_writel(tqspi, val, QSPI_GLOBAL_CONFIG); > > I notice that nothing seems to clear QSPI_CMB_SEQ_EN - is that self > clearing or something? Need a change in non-combined sequence code to reset this. Will add the change in v3
| |