lkml.org 
[lkml]   [2022]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Error when compiling kernel module - Re: More power management updates for v5.17-rc1
Hi Rafael,

Le lun., févr. 21 2022 at 17:44:28 +0100, Rafael J. Wysocki
<rafael@kernel.org> a écrit :
> On Mon, Feb 21, 2022 at 5:29 PM Paul Cercueil <paul@crapouillou.net>
> wrote:
>>
>> Hi Rafael,
>>
>> Le lun., févr. 21 2022 at 17:18:51 +0100, Rafael J. Wysocki
>> <rafael@kernel.org> a écrit :
>> > On Mon, Feb 21, 2022 at 1:15 PM eh kernel <ehkernel@gmail.com>
>> wrote:
>> >>
>> >> Hi Rafael,
>> >>
>> >> I now get an error when compiling the kernel module
>> (out-of-tree)
>> >> with the new PM macros.
>> >>
>> >> /home/ubuntu/pressure/bmp280-core.c:1163:28: error: expected
>> >> ‘)’ before ‘(’ token
>> >> 1163 | bmp280_runtime_resume, NULL);
>> >
>> > Which of the macros has triggered this error?
>>
>> I think the bug was introduced by 23a133c1ba67 ("iio:adc:ab8500:
>> Switch
>> from CONFIG_PM guards to pm_ptr() etc")
>>
>> The macro takes 4 arguments and its first parameter should be the
>> dev_pm_ops name, so "ab8500_gpadc_pm_ops".
>>
>> It slipped during review.
>
> I see.
>
> Can you fix this, please?

Jonathan already fixed it in his tree.

Cheers,
-Paul


\
 
 \ /
  Last update: 2022-02-23 12:46    [W:0.042 / U:0.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site