Messages in this thread | | | Date | Wed, 23 Feb 2022 16:57:40 +0800 | From | Yue Hu <> | Subject | Re: [PATCH] erofs: fix ztailpacking on > 4GiB filesystems |
| |
On Tue, 22 Feb 2022 11:31:18 +0800 Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> z_idataoff here is an absolute physical offset, so it should use > erofs_off_t (64 bits at least). Otherwise, it'll get trimmed and > cause the decompresion failure. > > Fixes: ab92184ff8f1 ("erofs: add on-disk compressed tail-packing inline support") > Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com> > --- > fs/erofs/internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h > index b8272fb95fd6..5aa2cf2c2f80 100644 > --- a/fs/erofs/internal.h > +++ b/fs/erofs/internal.h > @@ -325,7 +325,7 @@ struct erofs_inode { > unsigned char z_algorithmtype[2]; > unsigned char z_logical_clusterbits; > unsigned long z_tailextent_headlcn; > - unsigned int z_idataoff; > + erofs_off_t z_idataoff; > unsigned short z_idata_size; > }; > #endif /* CONFIG_EROFS_FS_ZIP */
Reviewed-by: Yue Hu <huyue2@yulong.com>
| |