Messages in this thread | | | Date | Mon, 21 Feb 2022 12:49:12 +0100 | From | Jonathan Neuschäfer <> | Subject | Re: [PATCH v2 05/11] i2c: npcm: Remove unused clock node |
| |
On Sun, Feb 20, 2022 at 11:53:15AM +0800, Tyrone Ting wrote: > From: Tali Perry <tali.perry1@gmail.com> > > Remove unused npcm750-clk node.
You're not actually removing a node, for example in the sense of removing a devicetree node from a devicetree.
So, I think "Remove unused variable clk_regmap." would be a better description.
> > Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver") > Signed-off-by: Tali Perry <tali.perry1@gmail.com> > Signed-off-by: Tyrone Ting <kfting@nuvoton.com> > --- > drivers/i2c/busses/i2c-npcm7xx.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c > index a51db3f50274..9ccb9958945e 100644 > --- a/drivers/i2c/busses/i2c-npcm7xx.c > +++ b/drivers/i2c/busses/i2c-npcm7xx.c > @@ -2233,7 +2233,6 @@ static int npcm_i2c_probe_bus(struct platform_device *pdev) > struct i2c_adapter *adap; > struct clk *i2c_clk; > static struct regmap *gcr_regmap; > - static struct regmap *clk_regmap; > int irq; > int ret; > struct device_node *np = pdev->dev.of_node; > @@ -2256,10 +2255,6 @@ static int npcm_i2c_probe_bus(struct platform_device *pdev) > return PTR_ERR(gcr_regmap); > regmap_write(gcr_regmap, NPCM_I2CSEGCTL, NPCM_I2CSEGCTL_INIT_VAL); > > - clk_regmap = syscon_regmap_lookup_by_compatible("nuvoton,npcm750-clk"); > - if (IS_ERR(clk_regmap)) > - return PTR_ERR(clk_regmap); > -
The change itself looks good to me,
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> bus->reg = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(bus->reg)) > return PTR_ERR(bus->reg); > -- > 2.17.1 >
Thanks, Jonathan [unhandled content-type:application/pgp-signature] | |