lkml.org 
[lkml]   [2022]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v16 21/40] pwm: tegra: Add runtime PM and OPP support
    From
    Hello Uwe,

    21.02.2022 11:17, Uwe Kleine-König пишет:
    >> @@ -344,7 +387,10 @@ static const struct of_device_id tegra_pwm_of_match[] = {
    >> MODULE_DEVICE_TABLE(of, tegra_pwm_of_match);
    >>
    >> static const struct dev_pm_ops tegra_pwm_pm_ops = {
    >> - SET_SYSTEM_SLEEP_PM_OPS(tegra_pwm_suspend, tegra_pwm_resume)
    >> + SET_RUNTIME_PM_OPS(tegra_pwm_runtime_suspend, tegra_pwm_runtime_resume,
    >> + NULL)
    >> + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
    >> + pm_runtime_force_resume)
    >> };
    >>
    >> static struct platform_driver tegra_pwm_driver = {
    > I admit to not completely understand the effects of this patch, but I
    > don't see a problem either. So for me this patch is OK:
    >
    > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    >
    > I spot a problem, it's not introduced by this patch however: If the
    > consumer of the PWM didn't stop the hardware, the suspend should IMHO be
    > prevented.

    Why? The PWM driver itself will stop the h/w on suspend.

    > I wonder if the patches in this series go in in one go via an ARM or
    > Tegra tree, or each patch via its respective maintainer tree.

    This series, including this patch, was already applied to 5.17 via the
    tegra/soc tree. No action is needed anymore.

    \
     
     \ /
      Last update: 2022-02-21 19:50    [W:4.776 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site