lkml.org 
[lkml]   [2022]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] dt-bindings: memory: lpddr2: Adjust revision ID property to match lpddr3
From
On 19/02/2022 02:24, Julius Werner wrote:
> Commit 3539a2 (dt-bindings: memory: lpddr2: Add revision-id properties)
> added the properties `revision-id1` and `revision-id2` to the
> "jedec,lpddr2" binding. The "jedec,lpddr3" binding already had a single
> array property `revision-id` for the same purpose. For consistency
> between related memory types, this patch deprecates the LPDDR2
> properties and instead adds a property in the same style as for LPDDR3
> to that binding.
>
> Signed-off-by: Julius Werner <jwerner@chromium.org>
> ---
> .../memory-controllers/ddr/jedec,lpddr2.yaml | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
> index 25ed0266f6dd3d..37229738f47271 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
> @@ -30,12 +30,23 @@ properties:
> maximum: 255
> description: |
> Revision 1 value of SDRAM chip. Obtained from device datasheet.
> + Property is deprecated, use revision-id instead.
> + deprecated: true
>
> revision-id2:
> $ref: /schemas/types.yaml#/definitions/uint32
> maximum: 255
> description: |
> Revision 2 value of SDRAM chip. Obtained from device datasheet.
> + Property is deprecated, use revision-id instead.
> + deprecated: true
> +
> + revision-id:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 2
> + maxItems: 2

You need maximum value under items. See:
Documentation/devicetree/bindings/arm/l2c2x0.yaml

> + description: |
> + Revision IDs read from Mode Register 6 and 7. One byte per uint32 cell (i.e. <MR6 MR7>).
>
> density:
> $ref: /schemas/types.yaml#/definitions/uint32
> @@ -164,8 +175,7 @@ examples:
> compatible = "elpida,ECB240ABACN", "jedec,lpddr2-s4";
> density = <2048>;
> io-width = <32>;
> - revision-id1 = <1>;
> - revision-id2 = <0>;
> + revision-id = <123 234>;

Don't change the original values.

Plus what Dmitry pointed out.

>
> tRPab-min-tck = <3>;
> tRCD-min-tck = <3>;


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-02-19 16:42    [W:0.051 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site