lkml.org 
[lkml]   [2022]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/29] x86/module: Fix the paravirt vs alternative order
    On Fri, Feb 18, 2022 at 10:22:46PM +0100, Peter Zijlstra wrote:
    > On Fri, Feb 18, 2022 at 12:28:20PM -0800, Josh Poimboeuf wrote:
    > > On Fri, Feb 18, 2022 at 05:49:04PM +0100, Peter Zijlstra wrote:
    > > > Ever since commit 4e6292114c741 ("x86/paravirt: Add new features for
    > > > paravirt patching") there is an ordering dependency between patching
    > > > paravirt ops and patching alternatives, the module loader still
    > > > violates this.
    > > >
    > > > Fixes: 4e6292114c741 ("x86/paravirt: Add new features for paravirt patching")
    > > > Cc: Juergen Gross <jgross@suse.com>
    > > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    > >
    > > Probably a good idea to put the 'para' and 'alt' clauses next to each
    > > other and add a comment that the ordering is necessary.
    >
    > Can't, retpolines must be in between, but I'll add a comment to check
    > alternative.c for ordering constraints.

    Ah, even more justification for a comment then ;-)

    --
    Josh

    \
     
     \ /
      Last update: 2022-02-19 00:29    [W:8.255 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site