lkml.org 
[lkml]   [2022]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] dt-bindings: rtc: convert at91sam9 bindings to json-schema
    Date
    Hello,

    On 17.02.2022 00:51, Rob Herring wrote:
    > On Tue, 15 Feb 2022 16:46:49 +0200, Sergiu Moga wrote:
    >> Convert RTC binding for Atmel/Microchip SoCs to Device Tree Schema
    >> format.
    >>
    >> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
    >> ---
    >> .../bindings/rtc/atmel,at91sam9-rtc.txt | 25 --------
    >> .../bindings/rtc/atmel,at91sam9-rtc.yaml | 61 +++++++++++++++++++
    >> 2 files changed, 61 insertions(+), 25 deletions(-)
    >> delete mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
    >> create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
    >>
    > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
    > on your patch (DT_CHECKER_FLAGS is new in v5.13):
    >
    > yamllint warnings/errors:
    > ./Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml:20:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
    > ./Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml:22:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
    >
    > dtschema/dtc warnings/errors:
    > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.example.dt.yaml: rtt@fffffd20: $nodename:0: 'rtt@fffffd20' does not match '^rtc(@.*|-[0-9a-f])*$'
    > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
    > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.example.dt.yaml: rtt@fffffd20: atmel,rtt-rtc-time-reg:0: [4294967295, 0] is too long
    > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
    >
    > doc reference errors (make refcheckdocs):
    >
    > See https://patchwork.ozlabs.org/patch/1593106
    >
    > This check can fail if there are any dependencies. The base for a patch
    > series is generally the most recent rc1.
    >
    > If you already ran 'make dt_binding_check' and didn't see the above
    > error(s), then make sure 'yamllint' is installed and dt-schema is up to
    > date:
    >
    > pip3 install dtschema --upgrade
    >
    > Please check and re-submit.
    >
    My apologies, it seems that, by mistake, I used the wrong file for
    DT_SCHEMA_FILES and thus I did not see any warnings or errors. I will
    correct this in the next version.

    Thank you for the feedback.

    Sergiu

    \
     
     \ /
      Last update: 2022-02-17 13:08    [W:3.262 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site