lkml.org 
[lkml]   [2022]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC V4 3/6] blk-iolatency: make iolatency pluggable
    From


    On 2022/2/17 4:51 下午, Christoph Hellwig wrote:
    >> +static inline struct rq_qos *blkcg_rq_qos(struct request_queue *q)
    >> +{
    >> + return rq_qos_by_id(q, blkcg_iolatency_ops.id);
    >> +}
    >
    > This just has a single user, so open code it.
    >
    >> +static int blk_iolatency_init(struct request_queue *q);
    >> +
    >> static struct rq_qos_ops blkcg_iolatency_ops = {
    >> + .name = "blk-iolat",
    >> + .flags = RQOS_FLAG_CGRP_POL,
    >> .throttle = blkcg_iolatency_throttle,
    >> .done_bio = blkcg_iolatency_done_bio,
    >> .exit = blkcg_iolatency_exit,
    >> + .init = blk_iolatency_init,
    >> };
    >
    > I'd move this structure below blk_iolatency_init to avoid the forward
    > declaration of blk_iolatency_init

    Got it

    Thanks
    Jianchao

    \
     
     \ /
      Last update: 2022-02-18 04:44    [W:3.174 / U:0.840 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site