lkml.org 
[lkml]   [2022]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net] Revert "net: ethernet: bgmac: Use devm_platform_ioremap_resource_byname"
On Wed, Feb 16, 2022 at 10:46:34AM -0800, Florian Fainelli wrote:
> From: Jonas Gorski <jonas.gorski@gmail.com>
>
> This reverts commit 3710e80952cf2dc48257ac9f145b117b5f74e0a5.
>
> Since idm_base and nicpm_base are still optional resources not present
> on all platforms, this breaks the driver for everything except Northstar
> 2 (which has both).
>
> The same change was already reverted once with 755f5738ff98 ("net:
> broadcom: fix a mistake about ioremap resource").
>
> So let's do it again.
>
> - bgmac->plat.idm_base = devm_platform_ioremap_resource_byname(pdev, "idm_base");
> - if (IS_ERR(bgmac->plat.idm_base))
> - return PTR_ERR(bgmac->plat.idm_base);
> - else
> + /* The idm_base resource is optional for some platforms */

I see you are adding a comment. Good idea. Lets see if the bot
handlers are clever enough to actually read it, or just blindly do
what the bot says to do, without actually trying to understand the
code.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Andrew

\
 
 \ /
  Last update: 2022-02-16 20:02    [W:0.069 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site