lkml.org 
[lkml]   [2022]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] perf tools: Remove redundant err variable
Em Wed, Feb 16, 2022 at 11:04:25AM +0800, tangmeng escreveu:
> The variable err in the perf_event__process_sample is only used
> in the only one judgment statement, it is not used in other places.
>
> So, use the return value from hist_entry_iter__add() directly
> instead of taking this in another redundant variable.

Thanks, applied.

- Arnaldo


> Signed-off-by: tangmeng <tangmeng@uniontech.com>
> ---
> tools/perf/builtin-top.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index 1fc390f136dd..3c8c60b7f6f0 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -746,7 +746,6 @@ static void perf_event__process_sample(struct perf_tool *tool,
> {
> struct perf_top *top = container_of(tool, struct perf_top, tool);
> struct addr_location al;
> - int err;
>
> if (!machine && perf_guest) {
> static struct intlist *seen;
> @@ -839,8 +838,7 @@ static void perf_event__process_sample(struct perf_tool *tool,
>
> pthread_mutex_lock(&hists->lock);
>
> - err = hist_entry_iter__add(&iter, &al, top->max_stack, top);
> - if (err < 0)
> + if (hist_entry_iter__add(&iter, &al, top->max_stack, top) < 0)
> pr_err("Problem incrementing symbol period, skipping event\n");
>
> pthread_mutex_unlock(&hists->lock);
> --
> 2.20.1
>
>

--

- Arnaldo

\
 
 \ /
  Last update: 2022-02-16 14:39    [W:0.034 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site