lkml.org 
[lkml]   [2022]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/4] hwmon: (occ) Add sysfs entry for OCC mode
On Tue, 15 Feb 2022 at 15:11, Eddie James <eajames@linux.ibm.com> wrote:
>
> BMC control applications need to check the OCC mode returned by the
> OCC poll response, so export it in sysfs with the other OCC-specific
> data.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>

Reviewed-by: Joel Stanley <joel@jms.id.au>

> ---
> drivers/hwmon/occ/common.h | 1 +
> drivers/hwmon/occ/sysfs.c | 11 +++++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/drivers/hwmon/occ/common.h b/drivers/hwmon/occ/common.h
> index a88c66d36e38..2dd4a4d240c0 100644
> --- a/drivers/hwmon/occ/common.h
> +++ b/drivers/hwmon/occ/common.h
> @@ -120,6 +120,7 @@ struct occ {
> u8 prev_ext_stat;
> u8 prev_occs_present;
> u8 prev_ips_status;
> + u8 prev_mode;
> };
>
> int occ_setup(struct occ *occ, const char *name);
> diff --git a/drivers/hwmon/occ/sysfs.c b/drivers/hwmon/occ/sysfs.c
> index 6dc69c9aa4c2..88f655887c95 100644
> --- a/drivers/hwmon/occ/sysfs.c
> +++ b/drivers/hwmon/occ/sysfs.c
> @@ -66,6 +66,9 @@ static ssize_t occ_sysfs_show(struct device *dev,
> case 8:
> val = header->ips_status;
> break;
> + case 9:
> + val = header->mode;
> + break;
> default:
> return -EINVAL;
> }
> @@ -92,6 +95,7 @@ static SENSOR_DEVICE_ATTR(occ_quick_pwr_drop, 0444, occ_sysfs_show, NULL, 5);
> static SENSOR_DEVICE_ATTR(occ_state, 0444, occ_sysfs_show, NULL, 6);
> static SENSOR_DEVICE_ATTR(occs_present, 0444, occ_sysfs_show, NULL, 7);
> static SENSOR_DEVICE_ATTR(occ_ips_status, 0444, occ_sysfs_show, NULL, 8);
> +static SENSOR_DEVICE_ATTR(occ_mode, 0444, occ_sysfs_show, NULL, 9);
> static DEVICE_ATTR_RO(occ_error);
>
> static struct attribute *occ_attributes[] = {
> @@ -104,6 +108,7 @@ static struct attribute *occ_attributes[] = {
> &sensor_dev_attr_occ_state.dev_attr.attr,
> &sensor_dev_attr_occs_present.dev_attr.attr,
> &sensor_dev_attr_occ_ips_status.dev_attr.attr,
> + &sensor_dev_attr_occ_mode.dev_attr.attr,
> &dev_attr_occ_error.attr,
> NULL
> };
> @@ -172,6 +177,11 @@ void occ_sysfs_poll_done(struct occ *occ)
> sysfs_notify(&occ->bus_dev->kobj, NULL, name);
> }
>
> + if (header->mode != occ->prev_mode) {
> + name = sensor_dev_attr_occ_mode.dev_attr.attr.name;
> + sysfs_notify(&occ->bus_dev->kobj, NULL, name);
> + }
> +
> if (occ->error && occ->error != occ->prev_error) {
> name = dev_attr_occ_error.attr.name;
> sysfs_notify(&occ->bus_dev->kobj, NULL, name);
> @@ -185,6 +195,7 @@ void occ_sysfs_poll_done(struct occ *occ)
> occ->prev_ext_stat = header->ext_status;
> occ->prev_occs_present = header->occs_present;
> occ->prev_ips_status = header->ips_status;
> + occ->prev_mode = header->mode;
> }
>
> int occ_setup_sysfs(struct occ *occ)
> --
> 2.27.0
>

\
 
 \ /
  Last update: 2022-02-16 07:14    [W:0.147 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site