lkml.org 
[lkml]   [2022]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] ath9k: use hw_random API instead of directly dumping into random.c
Date
"Jason A. Donenfeld" <Jason@zx2c4.com> writes:

> Hardware random number generators are supposed to use the hw_random
> framework. This commit turns ath9k's kthread-based design into a proper
> hw_random driver.
>
> This compiles, but I have no hardware or other ability to determine
> whether it works. I'll leave further development up to the ath9k
> and hw_random maintainers.
>
> Cc: Toke Høiland-Jørgensen <toke@redhat.com>
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: Dominik Brodowski <linux@dominikbrodowski.net>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

[...]

> +retry:
> + if (max & ~3UL)
> + bytes_read = ath9k_rng_data_read(sc, buf, max >> 2);
> + if ((max & 3UL) && ath9k_rng_data_read(sc, &word, 1)) {
> + memcpy(buf + bytes_read, &word, max & 3);
> + bytes_read += max & 3;
> + memzero_explicit(&word, sizeof(word));
> + }
> + if (max && unlikely(!bytes_read) && wait) {
> + msleep(ath9k_rng_delay_get(++fail_stats));
> + goto retry;
> }

Wouldn't a while loop be cleaner? With a some kind limit for the number
of loops, to avoid a neverending loop.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

\
 
 \ /
  Last update: 2022-02-16 06:41    [W:0.096 / U:1.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site