lkml.org 
[lkml]   [2022]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/6] mm/page_alloc: Fetch the correct pcp buddy during bulk free
    Date
    free_pcppages_bulk() prefetches buddies about to be freed but the
    order must also be passed in as PCP lists store multiple orders.

    Fixes: 44042b449872 ("mm/page_alloc: allow high-order pages to be stored on the per-cpu lists")
    Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
    Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
    ---
    mm/page_alloc.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/mm/page_alloc.c b/mm/page_alloc.c
    index 3589febc6d31..08de32cfd9bb 100644
    --- a/mm/page_alloc.c
    +++ b/mm/page_alloc.c
    @@ -1432,10 +1432,10 @@ static bool bulkfree_pcp_prepare(struct page *page)
    }
    #endif /* CONFIG_DEBUG_VM */

    -static inline void prefetch_buddy(struct page *page)
    +static inline void prefetch_buddy(struct page *page, unsigned int order)
    {
    unsigned long pfn = page_to_pfn(page);
    - unsigned long buddy_pfn = __find_buddy_pfn(pfn, 0);
    + unsigned long buddy_pfn = __find_buddy_pfn(pfn, order);
    struct page *buddy = page + (buddy_pfn - pfn);

    prefetch(buddy);
    @@ -1512,7 +1512,7 @@ static void free_pcppages_bulk(struct zone *zone, int count,
    * prefetch buddy for the first pcp->batch nr of pages.
    */
    if (prefetch_nr) {
    - prefetch_buddy(page);
    + prefetch_buddy(page, order);
    prefetch_nr--;
    }
    } while (count > 0 && --batch_free && !list_empty(list));
    --
    2.31.1
    \
     
     \ /
      Last update: 2022-02-17 01:24    [W:6.217 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site