lkml.org 
[lkml]   [2022]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC] scripts: kernel-doc: Major kernel-doc rework
Date
Tomasz Warniełło <tomasz.warniello@gmail.com> writes:

> This is in fact a release notification of a major kernel-doc script
> refurbishment I have done. My work has reached a stage, which can be
> considered a world sync point and here we are.
>
> I'm not sending all the patches to the Linux mailing list, as I prefer
> to check what you think before I emit about 500 emails.
>
> I've parked the lot for you to inspect here:
> https://salsa.debian.org/guest/kernel-doc
>
> This also helps me report the bug fixes. See the issue tracker:
> https://salsa.debian.org/guest/kernel-doc/-/issues

I've taken a quick look - that's a lot of stuff. Thanks for not sending
it all; you would have gotten some unhappy answers.

Some overall thoughts:

- Work like this needs to be broken up into digestible batches. Let's
start with the POD stuff that I've (finally) commented on; other
stuff can come later.

- The coding style in the new work is very unkernellike; that will make
it harder to get this work merged.

- But let's take a step back and ask: why are we doing all of this work
in the first place? What is the benefit to the kernel community from
all this churn, and a growth of the kernel-doc script by over 2,000
lines (even if an awful lot of them are blank)?

I'm serious about that last question; do we really want to invest that
kind of effort into this nasty old script? Or, if we're going to do
such a thing, should we maybe start with Markus's rewrite into Python
instead? If we're going to thrash the code and make it unrecognizable,
perhaps we should move to a language that is consistent with the rest of
the docs build system and which, I believe, is easier for more kernel
developers to deal with?

I am *not* saying that this work cannot be accepted, and I certainly do
not want to alienate somebody who is actually able to look at kernel-doc
and not have their eyes bleed out. But I am saying that, before
launching into a hundreds-of-patches journey, we should know where we're
going and why we are doing it.

See what I'm getting at?

Thanks,

jon

\
 
 \ /
  Last update: 2022-02-17 00:46    [W:0.085 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site