lkml.org 
[lkml]   [2022]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 34/75] mm/vmscan: Turn page_check_dirty_writeback() into folio_check_dirty_writeback()
On Sun, Feb 06, 2022 at 11:51:54PM -0800, Christoph Hellwig wrote:
> > - mapping = page_mapping(page);
> > + mapping = folio_mapping(folio);
> > if (mapping && mapping->a_ops->is_dirty_writeback)
> > - mapping->a_ops->is_dirty_writeback(page, dirty, writeback);
> > + mapping->a_ops->is_dirty_writeback(&folio->page, dirty, writeback);
>
> This adds an overly long line.

Yeah, I'm planning on taking care of it in 5.19 by switching
is_dirty_writeback() to take a folio.

> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>

\
 
 \ /
  Last update: 2022-02-12 02:50    [W:0.130 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site