Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sat, 12 Feb 2022 01:49:21 +0000 | From | Matthew Wilcox <> | Subject | Re: [PATCH 34/75] mm/vmscan: Turn page_check_dirty_writeback() into folio_check_dirty_writeback() |
| |
On Sun, Feb 06, 2022 at 11:51:54PM -0800, Christoph Hellwig wrote: > > - mapping = page_mapping(page); > > + mapping = folio_mapping(folio); > > if (mapping && mapping->a_ops->is_dirty_writeback) > > - mapping->a_ops->is_dirty_writeback(page, dirty, writeback); > > + mapping->a_ops->is_dirty_writeback(&folio->page, dirty, writeback); > > This adds an overly long line.
Yeah, I'm planning on taking care of it in 5.19 by switching is_dirty_writeback() to take a folio.
> Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@lst.de> >
| ![\](/images/icornerr.gif) |