lkml.org 
[lkml]   [2022]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v5 2/6] dsa: lan9303: move Turbo Mode bit initialization
    On Fri, 9 Dec 2022 16:47:09 -0600 Jerry Ray wrote:
    > In preparing to remove the .adjust_link api, I am moving the one-time
    > initialization of the device's Turbo Mode bit into a different execution
    > path. This code clears (disables) the Turbo Mode bit which is never used
    > by this driver. Turbo Mode is a non-standard mode that would allow the
    > 100Mbps RMII interface to run at 200Mbps.

    > @@ -1073,14 +1079,6 @@ static void lan9303_adjust_link(struct dsa_switch *ds, int port,
    > ctl &= ~BMCR_FULLDPLX;
    >
    > lan9303_phy_write(ds, port, MII_BMCR, ctl);
    > -
    > - if (port == chip->phy_addr_base) {
    > - /* Virtual Phy: Remove Turbo 200Mbit mode */
    > - lan9303_read(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, &ctl);
    > -
    > - ctl &= ~LAN9303_VIRT_SPECIAL_TURBO;
    > - regmap_write(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, ctl);
    > - }
    > }
    >
    > static int lan9303_port_enable(struct dsa_switch *ds, int port,

    The chip variable has to go, otherwise there will be a warning in
    bisection until patch 6 removes this entire function:

    drivers/net/dsa/lan9303-core.c:1059:18: warning: unused variable 'chip' [-Wunused-variable]
    struct lan9303 *chip = ds->priv;
    ^

    \
     
     \ /
      Last update: 2022-12-10 05:15    [W:3.077 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site