| Date | Thu, 8 Dec 2022 09:42:44 +0000 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v2 11/18] x86/sgx: Prepare for multiple LRUs |
| |
On Fri, Dec 02, 2022 at 10:36:47AM -0800, Kristen Carlson Accardi wrote: > From: Sean Christopherson <sean.j.christopherson@intel.com> > > Add sgx_can_reclaim() wrapper so that in a subsequent patch, multiple LRUs > can be used cleanly.
Nit: Patch is the transient form of a change. Once a change has been committed, it is a commit.
Further, you should instead explain why subsequent changes require sgx_can_reclaim() wrapper, than just claim it without argument.
Alternatively, you can consider squashing this to the subsequent patch, which makes use of the wrapper.
BR, Jarkko
|