| Date | Thu, 8 Dec 2022 09:30:13 +0000 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v2 09/18] x86/sgx: Return the number of EPC pages that were successfully reclaimed |
| |
On Fri, Dec 02, 2022 at 10:36:45AM -0800, Kristen Carlson Accardi wrote: > From: Sean Christopherson <sean.j.christopherson@intel.com> > > Return the number of reclaimed pages from sgx_reclaim_pages(), the EPC > cgroup will use the result to track the success rate of its reclaim > calls, e.g. to escalate to a more forceful reclaiming mode if necessary. > > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> > Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com> > Cc: Sean Christopherson <seanjc@google.com> > --- > arch/x86/kernel/cpu/sgx/main.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/cpu/sgx/main.c b/arch/x86/kernel/cpu/sgx/main.c > index f201ca85212f..a4a65eadfb79 100644 > --- a/arch/x86/kernel/cpu/sgx/main.c > +++ b/arch/x86/kernel/cpu/sgx/main.c > @@ -291,7 +291,7 @@ static void sgx_reclaimer_write(struct sgx_epc_page *epc_page, > * problematic as it would increase the lock contention too much, which would > * halt forward progress. > */ > -static void __sgx_reclaim_pages(int nr_to_scan) > +static int __sgx_reclaim_pages(int nr_to_scan)
Nit: I wonder if we should use ssize_t here?
If nothing else, it would document better than 'int'.
BR, Jarkko
|