Messages in this thread Patch in this message | | | From | Li Qiong <> | Subject | [PATCH v2] netfilter: add a 'default' case to 'switch (tuplehash->tuple.xmit_type)' | Date | Tue, 6 Dec 2022 15:44:14 +0800 |
| |
Add a 'default' case in case return a uninitialized value of ret.
Signed-off-by: Li Qiong <liqiong@nfschina.com> --- v2: Add 'default' case instead of initializing 'ret'. --- net/netfilter/nf_flow_table_ip.c | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table_ip.c index b350fe9d00b0..19efba1e51ef 100644 --- a/net/netfilter/nf_flow_table_ip.c +++ b/net/netfilter/nf_flow_table_ip.c @@ -421,6 +421,10 @@ nf_flow_offload_ip_hook(void *priv, struct sk_buff *skb, if (ret == NF_DROP) flow_offload_teardown(flow); break; + default: + WARN_ON_ONCE(1); + ret = NF_DROP; + break; } return ret; @@ -682,6 +686,10 @@ nf_flow_offload_ipv6_hook(void *priv, struct sk_buff *skb, if (ret == NF_DROP) flow_offload_teardown(flow); break; + default: + WARN_ON_ONCE(1); + ret = NF_DROP; + break; } return ret; -- 2.11.0
| |