Messages in this thread | | | Date | Tue, 6 Dec 2022 11:12:46 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH v4 1/2] media: uvcvideo: Refactor streamon/streamoff |
| |
On (22/12/02 18:19), Ricardo Ribalda wrote: > @@ -840,13 +840,19 @@ static int uvc_ioctl_streamon(struct file *file, void *fh, [..] > + handle->is_streaming = !ret;
> @@ -857,15 +863,22 @@ static int uvc_ioctl_streamoff(struct file *file, void *fh, [..] > + handle->is_streaming = !!ret;
Had uvc_ioctl_streamABC() be 3 functions we would have seen
handle->is_streaming = !!!ret;
:)
[..]
A nit:
> struct uvc_fh { > struct v4l2_fh vfh; > + bool is_streaming;
That's a lot of padding.
> struct uvc_video_chain *chain; > struct uvc_streaming *stream; > enum uvc_handle_state state;
I guess is_streaming better be next to enum uvc_handle_state, in which case is_streaming should not change sizeof(uvc_fh) (at least so on 64-bit).
| |