Messages in this thread | | | Date | Sat, 31 Dec 2022 14:45:58 +0000 | From | Jonathan Cameron <> | Subject | Re: [PATCH v1 1/2] iio: adc: ti-adc128s052: Switch to use spi_get_device_match_data() |
| |
On Wed, 28 Dec 2022 11:59:53 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Fri, Dec 23, 2022 at 03:44:50PM +0000, Jonathan Cameron wrote: > > On Fri, 23 Dec 2022 15:22:42 +0000 > > Jonathan Cameron <jic23@kernel.org> wrote: > > > > > On Wed, 14 Dec 2022 13:49:43 +0200 > > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > > > > > > The spi_get_device_match_data() helps to get driver data from the > > > > firmware node or SPI ID table. Use it instead of open coding. > > > > > > > > While at it, switch ID tables to provide an acrual pointers to > > > > the configuration data. > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > --- > > > > > > > > Requires aea672d054a2 ("spi: Introduce spi_get_device_match_data() > > > > helper") which is part of upstream as of today. > > > > > > I rebased to get that (will rebase again on rc1). > > > > > > Applied to the togreg branch of iio.git and pushed out as testing > > > to keep 0-day busy over my holidays. > > > > I take it back... Build test failed... > > As comment on the first patch stays this requires an SPI core patch, which is > now the part of the v6.2-rc1. > > Can you reapply it taking the above into consideration? >
I should have been more specific though I do mention rebasing to get the patch above.. Doesn't build with it.
Signature of spi_get_device_match_data is: extern const void * spi_get_device_match_data(const struct spi_device *sdev);
and you are passing it a struct device * which rather implies you didn't successfully build test this.
Jonathan
| |