Messages in this thread | | | From | Frank Wunderlich <> | Subject | Aw: Re: Re: [PATCH net v3 4/5] net: ethernet: mtk_eth_soc: drop generic vlan rx offload, only use DSA untagging | Date | Fri, 30 Dec 2022 16:33:04 +0100 |
| |
Hi
> Gesendet: Freitag, 30. Dezember 2022 um 15:58 Uhr > Von: "Felix Fietkau" <nbd@nbd.name>
> Does this help? > --- > --- a/net/dsa/tag_mtk.c > +++ b/net/dsa/tag_mtk.c > @@ -25,6 +25,14 @@ static struct sk_buff *mtk_tag_xmit(stru > u8 xmit_tpid; > u8 *mtk_tag; > > + /* The Ethernet switch we are interfaced with needs packets to be at > + * least 64 bytes (including FCS) otherwise their padding might be > + * corrupted. With tags enabled, we need to make sure that packets are > + * at least 68 bytes (including FCS and tag). > + */ > + if (__skb_put_padto(skb, ETH_ZLEN + MTK_HDR_LEN, false)) > + return NULL; > + > /* Build the special tag after the MAC Source Address. If VLAN header > * is present, it's required that VLAN header and special tag is > * being combined. Only in this way we can allow the switch can parse
no, i verified my vlan-setup ist right by adding additional device (my r2) into the same 2 vlans. My Laptop can ping both vlans of R2, but on r3/mt7986 only vlan500 (on eth1) works, not 600 on wan-port of mt7986.
see arp going out on r3, but not received in the other side (laptop/r2)....
any debug i can add for this? ethtool does not show stats for vlans, for wan i see no CRC/drops
regards Frank
| |