Messages in this thread | | | Date | Fri, 30 Dec 2022 13:45:07 +0100 | From | Miquel Raynal <> | Subject | Re: [PATCH 1/3] mtd: rawnand: hynix: Add support for H27UCG8T2FTR-BC MLC NAND |
| |
Hi Samuel,
samuel@sholland.org wrote on Thu, 29 Dec 2022 13:09:03 -0600:
> H27UCG8T2FTR-BC is similar to the already-supported H27UCG8T2ETR-BC, but > reports a different ID.
Can you provide a datasheet for this part? I am surprised by the page size. In general anyway, it's best to provide a link when adding support for a new component.
Also, for your two series, no need to resend this time, but please use git-format-patch and git-send-email to create your series, so that all the patches are answers of the cover letter. It helps keeping all patches and answers in the series packed together.
Thanks! Miquèl
> Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > > drivers/mtd/nand/raw/nand_hynix.c | 4 ++++ > drivers/mtd/nand/raw/nand_ids.c | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/mtd/nand/raw/nand_hynix.c b/drivers/mtd/nand/raw/nand_hynix.c > index 0d4d4bbfdece..836f152612ab 100644 > --- a/drivers/mtd/nand/raw/nand_hynix.c > +++ b/drivers/mtd/nand/raw/nand_hynix.c > @@ -721,6 +721,10 @@ static int hynix_nand_init(struct nand_chip *chip) > sizeof("H27UCG8T2ETR-BC") - 1)) > h27ucg8t2etrbc_init(chip); > > + if (!strncmp("H27UCG8T2FTR-BC", chip->parameters.model, > + sizeof("H27UCG8T2FTR-BC") - 1)) > + h27ucg8t2etrbc_init(chip); > + > ret = hynix_nand_rr_init(chip); > if (ret) > hynix_nand_cleanup(chip); > diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c > index dacc5529b3df..167183ccb9e9 100644 > --- a/drivers/mtd/nand/raw/nand_ids.c > +++ b/drivers/mtd/nand/raw/nand_ids.c > @@ -55,6 +55,10 @@ struct nand_flash_dev nand_flash_ids[] = { > { .id = {0xad, 0xde, 0x14, 0xa7, 0x42, 0x4a} }, > SZ_16K, SZ_8K, SZ_4M, NAND_NEED_SCRAMBLING, 6, 1664, > NAND_ECC_INFO(40, SZ_1K) }, > + {"H27UCG8T2FTR-BC 64G 3.3V 8-bit", > + { .id = {0xad, 0xde, 0x14, 0xab, 0x42, 0x4a} }, > + SZ_16K, SZ_8K, SZ_4M, NAND_NEED_SCRAMBLING, 6, 1664, > + NAND_ECC_INFO(40, SZ_1K) }, > {"TH58NVG2S3HBAI4 4G 3.3V 8-bit", > { .id = {0x98, 0xdc, 0x91, 0x15, 0x76} }, > SZ_2K, SZ_512, SZ_128K, 0, 5, 128, NAND_ECC_INFO(8, SZ_512) },
| |