lkml.org 
[lkml]   [2022]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3] Add support for the AYANEO AIR and AYANEO AIR Pro models of handheld devices. These devices use the same EC registers and logic as the One X Player mini AMD. Previous AYANEO models are not supported as they use a different EC and do not ha
    On Wed, Dec 28, 2022 at 4:10 PM Guenter Roeck <linux@roeck-us.net> wrote:
    >
    > On Wed, Dec 28, 2022 at 03:06:32PM -0800, Derek J. Clark wrote:
    > > The added devices are:
    > > - AYANEO AIR (AMD 5560U)
    > > - AYANEO AIR Pro (AMD 5560U)
    > > - AYANEO AIR Pro (AMD 5825U)
    >
    > Add:
    >
    > While at it, fix spelling error (appart -> apart).
    >
    To clarify, do you want this added to the patch description? There
    were a couple other spelling errors I fixed as well (PLayer -> Player,
    capabilities -> capabilities).
    I.E.

    Add:
    - AYANEO AIR (AMD 5560U)
    - AYANEO AIR Pro (AMD 5560U)
    - AYANEO AIR Pro (AMD 5825U)
    Fix spelling errors (appart -> apart, capabilities -> capabilities,
    PLayer -> Player).

    > > ---
    > > Bundled all cases that lead to break.
    > > Spelling and grammar fixes.
    > > More verbose description of supported devices.
    > > ---
    > > Signed-off-by: Derek J. Clark <derekjohn.clark@gmail.com>
    > > ---
    > > Documentation/hwmon/oxp-sensors.rst | 19 +++++++----
    > > MAINTAINERS | 1 +
    > > drivers/hwmon/oxp-sensors.c | 52 ++++++++++++++++++++++++-----
    > > 3 files changed, 56 insertions(+), 16 deletions(-)
    > >
    > > diff --git a/Documentation/hwmon/oxp-sensors.rst b/Documentation/hwmon/oxp-sensors.rst
    > > index 39c588ec5c50..7f6e8def5aef 100644
    > > --- a/Documentation/hwmon/oxp-sensors.rst
    > > +++ b/Documentation/hwmon/oxp-sensors.rst
    > > @@ -3,18 +3,21 @@
    > > Kernel driver oxp-sensors
    > > =========================
    > >
    > > -Author:
    > > +Authors:
    > > + - Derek John Clark <derekjohn.clark@gmail.com>
    > > - Joaquín Ignacio Aramendía <samsagax@gmail.com>
    > >
    > > -Description:
    > > +Description
    > > ------------
    >
    > I am not going to accept this. The change is POV, and it is unrelated to
    > this patch. Either submit a separate patch or let the person requesting
    > the change submit it. It is very unlikely that I am going to accept it,
    > though, since the change is POV, unnecessary, and the original author may
    > rightfully come back tomorrow and submit a revert.
    >
    > Really, seriously, please refrain from making such changes.
    >
    > Guenter
    >
    Understood, I will revert it in v4.

    Thanks.

    \
     
     \ /
      Last update: 2023-03-26 23:22    [W:3.628 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site