Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Wed, 28 Dec 2022 00:17:16 +0530 | From | Deepak R Varma <> | Subject | [PATCH] gpu: host1x: No need for Null pointer check before kfree |
| |
kfree() & vfree() internally performs NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().
Issue reported by ifnullfree.cocci Coccinelle semantic patch script.
Signed-off-by: Deepak R Varma <drv@mailo.com> --- drivers/gpu/host1x/fence.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c index df428bcbae69..42498902947f 100644 --- a/drivers/gpu/host1x/fence.c +++ b/drivers/gpu/host1x/fence.c @@ -93,8 +93,7 @@ static void host1x_syncpt_fence_release(struct dma_fence *f) { struct host1x_syncpt_fence *sf = to_host1x_fence(f);
- if (sf->waiter) - kfree(sf->waiter); + kfree(sf->waiter);
dma_fence_free(f); } -- 2.34.1
| ![\](/images/icornerr.gif) |