| From | Chen-Yu Tsai <> | Date | Mon, 26 Dec 2022 15:07:10 +0800 | Subject | Re: [PATCH v2 04/23] clk: mediatek: cpumux: Propagate struct device where possible |
| |
On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Take a pointer to a struct device in mtk_clk_register_cpumuxes() and > propagate the same to mtk_clk_register_cpumux() => clk_hw_register(). > Even though runtime pm is unlikely to be used with CPU muxes, this > helps with code consistency and possibly opens to commonization of > some mtk_clk_register_(x) functions. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
As with the gates patch, could we make the |struct device *| parameter the first one? Also for this case I think we could even drop the |struct device_node *| parameter.
Regards ChenYu
|