lkml.org 
[lkml]   [2022]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 038/606] drm/i2c/ch7006: Convert to i2c's .probe_new()
    From
    Hello Uwe,

    On 11/18/22 23:36, Uwe Kleine-König wrote:
    > The probe function doesn't make use of the i2c_device_id * parameter so it
    > can be trivially converted.
    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > ---
    > drivers/gpu/drm/i2c/ch7006_drv.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c
    > index 578b738859b9..e0476a5bf84c 100644
    > --- a/drivers/gpu/drm/i2c/ch7006_drv.c
    > +++ b/drivers/gpu/drm/i2c/ch7006_drv.c
    > @@ -386,7 +386,7 @@ static const struct drm_encoder_slave_funcs ch7006_encoder_funcs = {
    >
    > /* I2C driver functions */
    >
    > -static int ch7006_probe(struct i2c_client *client, const struct i2c_device_id *id)
    > +static int ch7006_probe(struct i2c_client *client)
    > {
    > uint8_t addr = CH7006_VERSION_ID;
    > uint8_t val;
    > @@ -495,7 +495,7 @@ static const struct dev_pm_ops ch7006_pm_ops = {
    >
    > static struct drm_i2c_encoder_driver ch7006_driver = {
    > .i2c_driver = {
    > - .probe = ch7006_probe,
    > + .probe_new = ch7006_probe,
    > .remove = ch7006_remove,
    >
    > .driver = {

    Looks good to me.

    Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

    --
    Best regards,

    Javier Martinez Canillas
    Core Platforms
    Red Hat

    \
     
     \ /
      Last update: 2023-03-26 23:18    [W:2.367 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site