Messages in this thread | | | Date | Thu, 22 Dec 2022 12:59:22 +0100 | From | Marijn Suijten <> | Subject | Re: [PATCH v12 2/2] arm64: dts: qcom: sagit: add initial device tree for sagit |
| |
On 2022-11-12 23:33:00, Dzmitry Sankouski wrote: > New device support - Xiaomi Mi6 phone
<snip>
> diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi > index 6a0e14382be8..6a5854333b2b 100644 > --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi > @@ -52,6 +52,14 @@ pm8998_pwrkey: pwrkey { > bias-pull-up; > linux,code = <KEY_POWER>; > }; > + > + pm8998_resin: resin { > + compatible = "qcom,pm8941-resin"; > + interrupts = <GIC_SPI 0x8 1 IRQ_TYPE_EDGE_BOTH>; > + debounce = <15625>; > + bias-pull-up; > + status = "disabled"; > + };
This should have been a separate patch, one that deduplicated overlapping nodes with existing msm8998 / sdm845 boards which all add this node individually to &pm8998_pon.
What's more, their override has the same node name and will be merged with this one without setting status = "okay", leading to all those boards suddenly having a broken resin key because they inherit your status="disabled".
Can you send a fix to address that, with proper Fixes: tag?
- Marijn
> }; > > pm8998_temp: temp-alarm@2400 { > -- > 2.30.2 >
| |