lkml.org 
[lkml]   [2022]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next 1/4] blk-iocost: track whether iocg is still online
On Sat, Dec 17, 2022 at 11:05:24AM +0800, Yu Kuai wrote:
> @@ -459,6 +459,8 @@ struct ioc_gq {
> struct blkg_policy_data pd;
> struct ioc *ioc;
>
> + bool online;

Nit: maybe tab align this field like the fields above it.

> +static void ioc_pd_offline(struct blkg_policy_data *pd)
> +{
> + struct ioc_gq *iocg = pd_to_iocg(pd);
> + struct ioc *ioc = iocg->ioc;
> + unsigned long flags;
> +
> + if (ioc) {

How could ioc be NULL here?

\
 
 \ /
  Last update: 2023-03-26 23:16    [W:0.065 / U:1.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site