Messages in this thread | | | From | Rob Herring <> | Date | Tue, 20 Dec 2022 08:04:33 -0600 | Subject | Re: [PATCH 1/2] dt-bindings: usb: snps,dwc3: Allow power-domains property |
| |
On Tue, Dec 20, 2022 at 1:34 AM Felipe Balbi <balbi@kernel.org> wrote: > > > Hi, > > Rob Herring <robh@kernel.org> writes: > > > The Rockchip RK3399 DWC3 node has 'power-domain' property which isn't > > allowed by the schema: > > > > usb@fe900000: Unevaluated properties are not allowed ('power-domains' was unexpected) > > > > Allow DWC3 nodes to have a single power-domains entry. We could instead > > move the power-domains property to the parent wrapper node, but the > > could be an ABI break (Linux shouldn't care). Also, we don't want to > > encourage the pattern of wrapper nodes just to define resources such as > > clocks, resets, power-domains, etc. when not necessary. > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > index 6d78048c4613..bcefd1c2410a 100644 > > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > @@ -91,6 +91,9 @@ properties: > > - usb2-phy > > - usb3-phy > > > > + power-domains: > > + maxItems: 1 > > AFAICT this can be incorrect. Also, you could have Cc the dwc3 > maintainer to get comments.
When we have a user with more and know what each one is, then we can extend it. All the other users (upstream), put 'power-domains' in the wrapper node. But this is what we need now for RK3399.
I used get_maintainers.pl. If that's the wrong output, fix it please.
Rob
| |