lkml.org 
[lkml]   [2022]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v9 3/8] cpuset: Rebuild root domain deadline accounting information
    On 12/19/22 09:07, Vincent Guittot wrote:
    > On Sat, 17 Dec 2022 at 00:35, Qais Yousef <qyousef@layalina.io> wrote:
    > >
    > > Hi
    > >
    > > On 07/19/19 15:59, Juri Lelli wrote:
    > > > When the topology of root domains is modified by CPUset or CPUhotplug
    > > > operations information about the current deadline bandwidth held in the
    > > > root domain is lost.
    > > >
    > > > This patch addresses the issue by recalculating the lost deadline
    > > > bandwidth information by circling through the deadline tasks held in
    > > > CPUsets and adding their current load to the root domain they are
    > > > associated with.
    > > >
    > > > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    > > > Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
    > > > ---
    > >
    > > We see that rebuild_root_domain() can take 10+ ms (I get a max of 20ms quite
    > > consistently) on suspend/resume.
    > >
    > > Do we actually need to rebuild_root_domain() if we're going through
    > > a suspend/resume cycle?
    >
    > During suspend to ram, there are cpus hotplug operation but If you use
    > suspend to idle, you will skip cpus hotplug operation and its
    > associated rebuild.

    Thanks Vincent. I'll check on that - but if we want to keep suspend to ram?
    Do we really to incur this hit?


    Thanks

    --
    Qais Yousef

    \
     
     \ /
      Last update: 2023-03-26 23:15    [W:2.237 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site