Messages in this thread | | | Date | Tue, 20 Dec 2022 15:26:20 +0530 | Subject | Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes | From | Bhavya Kapoor <> |
| |
Hi, please drop this patch since the interrupt values supplied for tscadc are incorrect.
On 08/11/22 23:48, Krzysztof Kozlowski wrote: > On 08/11/2022 08:32, Bhavya Kapoor wrote: >> J721S2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes >> for 8 channel ADCs for J721S2. >> >> Enable ADCs present on J721S2 soc. >> >> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> >> --- >> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ >> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 40 +++++++++++++++++++ >> 2 files changed, 54 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >> index b210cc07c539..de9cb40273be 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >> @@ -429,3 +429,17 @@ >> &main_mcan17 { >> status = "disabled"; >> }; >> + >> +&tscadc0 { >> + status = "okay"; >> + adc { >> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >> + }; >> +}; >> + >> +&tscadc1 { >> + status = "okay"; >> + adc { >> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >> + }; >> +}; >> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi >> index 4d1bfabd1313..47a7a6b500c2 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi >> @@ -299,4 +299,44 @@ >> ti,cpts-periodic-outputs = <2>; >> }; >> }; >> + >> + tscadc0: tscadc@40200000 { > Node names should be generic, so "adc" > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > Best regards, > Krzysztof >
| |