Messages in this thread | | | From | Pavan Chebbi <> | Date | Fri, 2 Dec 2022 13:20:36 +0530 | Subject | Re: [PATCH 1/2] net: encx24j600: Add parentheses to fix precedence |
| |
On Thu, Dec 1, 2022 at 11:04 PM Valentina Goncharenko <goncharenko.vp@ispras.ru> wrote: > > In functions regmap_encx24j600_phy_reg_read() and > regmap_encx24j600_phy_reg_write() in the conditions of the waiting > cycles for filling the variable 'ret' it is necessary to add parentheses > to prevent wrong assignment due to logical operations precedence. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: d70e53262f5c ("net: Microchip encx24j600 driver") > Signed-off-by: Valentina Goncharenko <goncharenko.vp@ispras.ru> > --- > drivers/net/ethernet/microchip/encx24j600-regmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/microchip/encx24j600-regmap.c b/drivers/net/ethernet/microchip/encx24j600-regmap.c > index 81a8ccca7e5e..2e337c7a5773 100644 > --- a/drivers/net/ethernet/microchip/encx24j600-regmap.c > +++ b/drivers/net/ethernet/microchip/encx24j600-regmap.c > @@ -359,7 +359,7 @@ static int regmap_encx24j600_phy_reg_read(void *context, unsigned int reg, > goto err_out; > > usleep_range(26, 100); > - while ((ret = regmap_read(ctx->regmap, MISTAT, &mistat) != 0) && > + while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) != 0) && > (mistat & BUSY)) > cpu_relax(); > > @@ -397,7 +397,7 @@ static int regmap_encx24j600_phy_reg_write(void *context, unsigned int reg, > goto err_out; > > usleep_range(26, 100); > - while ((ret = regmap_read(ctx->regmap, MISTAT, &mistat) != 0) && > + while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) != 0) && > (mistat & BUSY)) > cpu_relax(); > > -- > 2.25.1 > Makes sense to me. Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com> [unhandled content-type:application/pkcs7-signature] | |