Messages in this thread | | | From | Doug Anderson <> | Date | Fri, 2 Dec 2022 08:18:01 -0800 | Subject | Re: [PATCH v3 1/3] arm64: dts: qcom: sdm845-db845c: fix audio codec interrupt pin name |
| |
Hi,
On Fri, Dec 2, 2022 at 8:08 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Fri, Dec 2, 2022 at 7:57 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > > > > The pin config entry should have a string, not number, for the GPIO used > > as WCD9340 audio codec interrupt. > > > > Reported-by: Doug Anderson <dianders@chromium.org> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > --- > > > > Cc: Doug Anderson <dianders@chromium.org> > > > > Changes since v2: > > 1. New patch. > > --- > > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Presumably should have a "Fixes" tag since this is likely a true bug. > > Reviewed-by: Douglas Anderson <dianders@chromium.org>
FWIW, this got copy-pasta-ed to another place, which I just noticed as I'm looking at your v3. So while your change is correct, it'd be better to also fix "sdm845-xiaomi-beryllium-common.dtsi"
-Doug
| |