Messages in this thread | | | From | "Elliott, Robert (Servers)" <> | Subject | RE: [PATCH v4 10/24] crypto: x86/poly - limit FPU preemption | Date | Fri, 2 Dec 2022 16:15:23 +0000 |
| |
> -----Original Message----- > From: Herbert Xu <herbert@gondor.apana.org.au> > Sent: Friday, December 2, 2022 3:25 AM > To: Elliott, Robert (Servers) <elliott@hpe.com> > Subject: Re: [PATCH v4 10/24] crypto: x86/poly - limit FPU preemption > > On Fri, Dec 02, 2022 at 06:21:02AM +0000, Elliott, Robert (Servers) wrote: ... > BTW, just a minor nit but you can delete the cond_resched() call > because kernel_fpu_end()/preempt_enable() will do it anyway.
That happens under CONFIG_PREEMPTION=y (from include/Linux/preempt.h and arch/x86/include/asm/preempt.h)
Is calling cond_resched() still helpful if that is not the configuration?
| |