Messages in this thread Patch in this message | | | From | tzm <> | Subject | [PATCH] mm/mempolicy: failed to disable numa balancing | Date | Fri, 2 Dec 2022 22:16:30 +0800 |
| |
It will be failed to disable numa balancing policy permanently by passing <numa_balancing=disable> to boot cmdline parameters. The numabalancing_override variable is int and 1 for enable -1 for disable. So, !enumabalancing_override will always be true, which cause this bug.
Signed-off-by: tzm <tcm1030@163.com> --- mm/mempolicy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 61aa9aedb728..2789c0920293 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -2865,7 +2865,7 @@ static void __init check_numabalancing_enable(void) if (numabalancing_override) set_numabalancing_state(numabalancing_override == 1); - if (num_online_nodes() > 1 && !numabalancing_override) { + if (num_online_nodes() > 1 && (numabalancing_override == 1)) { pr_info("%s automatic NUMA balancing. Configure with numa_balancing= or the kernel.numa_balancing sysctl\n", numabalancing_default ? "Enabling" : "Disabling"); set_numabalancing_state(numabalancing_default); -- 2.27.0
| |