Messages in this thread Patch in this message | | | From | Johannes Thumshirn <> | Subject | [PATCH 2/2] mcb: mcb-parse: fix error handing in chameleon_parse_gdd() | Date | Fri, 2 Dec 2022 01:38:50 -0800 |
| |
From: Yang Yingliang <yangyingliang@huawei.com>
If mcb_device_register() returns error in chameleon_parse_gdd(), the refcount of bus and device name are leaked. Fix this by calling put_device() to give up the reference, so they can be released in mcb_release_dev() and kobject_cleanup().
Fixes: 3764e82e5150 ("drivers: Introduce MEN Chameleon Bus") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Johannes Thumshirn <jth@kernel.org> Signed-off-by: Johannes Thumshirn <jth@kernel.org> --- drivers/mcb/mcb-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c index 0266bfddfbe2..aa6938da0db8 100644 --- a/drivers/mcb/mcb-parse.c +++ b/drivers/mcb/mcb-parse.c @@ -108,7 +108,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus, return 0; err: - mcb_free_dev(mdev); + put_device(&mdev->dev); return ret; } -- 2.37.3
| |