lkml.org 
[lkml]   [2022]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: ipa: use sysfs_emit() to instead of scnprintf()
From
On 12/2/22 2:42 AM, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.

The buffer passed is non-null and the existing code properly
limits the buffer to PAGE_SIZE.

But... OK.

Reviewed-by: Alex Elder <elder@linaro.org>

>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/net/ipa/ipa_sysfs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_sysfs.c b/drivers/net/ipa/ipa_sysfs.c
> index 5cbc15a971f9..14bd2f903045 100644
> --- a/drivers/net/ipa/ipa_sysfs.c
> +++ b/drivers/net/ipa/ipa_sysfs.c
> @@ -46,7 +46,7 @@ version_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> struct ipa *ipa = dev_get_drvdata(dev);
>
> - return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_version_string(ipa));
> + return sysfs_emit(buf, "%s\n", ipa_version_string(ipa));
> }
>
> static DEVICE_ATTR_RO(version);
> @@ -70,7 +70,7 @@ static ssize_t rx_offload_show(struct device *dev,
> {
> struct ipa *ipa = dev_get_drvdata(dev);
>
> - return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_offload_string(ipa));
> + return sysfs_emit(buf, "%s\n", ipa_offload_string(ipa));
> }
>
> static DEVICE_ATTR_RO(rx_offload);
> @@ -80,7 +80,7 @@ static ssize_t tx_offload_show(struct device *dev,
> {
> struct ipa *ipa = dev_get_drvdata(dev);
>
> - return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_offload_string(ipa));
> + return sysfs_emit(buf, "%s\n", ipa_offload_string(ipa));
> }
>
> static DEVICE_ATTR_RO(tx_offload);

\
 
 \ /
  Last update: 2022-12-02 23:21    [W:0.074 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site