lkml.org 
[lkml]   [2022]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 03/18] x86/sgx: Add 'struct sgx_epc_lru_lists' to encapsulate lru list(s)
    From
    On 12/2/22 10:36, Kristen Carlson Accardi wrote:
    > Introduce a data structure to wrap the existing reclaimable list
    > and its spinlock in a struct to minimize the code changes needed
    > to handle multiple LRUs as well as reclaimable and non-reclaimable
    > lists, both of which will be introduced and used by SGX EPC cgroups.
    >
    > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
    > Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
    > Cc: Sean Christopherson <seanjc@google.com>

    Tiny nits: Let's also allude to the fact that this doesn't do anything
    with the new helpers or structures for now.

    I also think it's probably a sane idea to mention that the core VM also
    has parallel LRU lists for cgroups.

    > +static inline struct sgx_epc_page *
    > +sgx_epc_pop_reclaimable(struct sgx_epc_lru_lists *lrus)
    > +{
    > + return __sgx_epc_page_list_pop(&(lrus)->reclaimable);
    > +}

    Are those '(lrus)' parenthesis doing anything useful?

    \
     
     \ /
      Last update: 2022-12-02 22:40    [W:4.082 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site