Messages in this thread | | | Date | Fri, 2 Dec 2022 13:31:14 -0800 | From | Ira Weiny <> | Subject | Re: [PATCH V2 02/11] cxl/mem: Implement Get Event Records command |
| |
On Fri, Dec 02, 2022 at 12:00:59AM -0500, Steven Rostedt wrote: > On Thu, 1 Dec 2022 23:40:52 -0500 > Steven Rostedt <rostedt@goodmis.org> wrote: > > > +#undef __print_symbolic > > +#define __print_symbolic(value, symbol_array...) \ > > + ({ \ > > + static const struct trace_print_flags symbols[] = \ > > + { symbol_array, { -1, NULL }}; \ > > + __print_symbolic_str(value, symbols); \ > > + }) > > + > > #endif /* CREATE_TRACE_POINTS */ > > Bah, I want this outside that #ifdef > > > diff --git a/include/trace/stages/stage7_class_define.h b/include/trace/stages/stage7_class_define.h > > index 8a7ec24c246d..6fe83397f65d 100644 > > --- a/include/trace/stages/stage7_class_define.h > > +++ b/include/trace/stages/stage7_class_define.h > > @@ -6,7 +6,6 @@ > > I also don't think I need to touch stage7. > > New patch:
I'm still going to defer this but will include a follow up patch to add this back in after the bulk of the series gets in.
Thanks for helping here. I still want to understand this all better but I have to focus on the main features ATM.
Thanks again! Ira
> > diff --git a/include/trace/define_trace.h b/include/trace/define_trace.h > index 00723935dcc7..9d665f634614 100644 > --- a/include/trace/define_trace.h > +++ b/include/trace/define_trace.h > @@ -133,3 +133,24 @@ > #define CREATE_TRACE_POINTS > > #endif /* CREATE_TRACE_POINTS */ > + > +#ifndef __DEFINE_PRINT_SYMBOLIC_STR > +#define __DEFINE_PRINT_SYMBOLIC_STR > +static inline const char * > +__print_symbolic_str(int type, struct trace_print_flags *symbols) > +{ > + for (; symbols->name != NULL; symbols++) { > + if (type == symbols->mask) > + return symbols->name; > + } > + return "<invalid>"; > +} > +#endif > + > +#undef __print_symbolic > +#define __print_symbolic(value, symbol_array...) \ > + ({ \ > + static const struct trace_print_flags symbols[] = \ > + { symbol_array, { -1, NULL }}; \ > + __print_symbolic_str(value, symbols); \ > + })
| |