Messages in this thread | | | Date | Fri, 2 Dec 2022 13:17:19 -0800 | From | Kees Cook <> | Subject | Re: [PATCH] random: Include <linux/once.h> in the right header |
| |
On Fri, Dec 02, 2022 at 10:13:36PM +0100, Christophe JAILLET wrote: > <linux/prandom.h> uses DO_ONCE(). So it should include <linux/once.h> > directly. > > On the contrary, <linux/random.h> doesn't use functionalities from > <linux/once.h>, so it should be removed. > > All this is true since commit c0842fbc1b18 ("random32: move the > pseudo-random 32-bit definitions to prandom.h") > > Move the #include <linux/once.h> in the right file. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |