lkml.org 
[lkml]   [2022]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] net: microchip: sparx5: Fix missing destroy_workqueue of mact_queue
On Thu, Dec 1, 2022 at 6:57 PM Qiheng Lin <linqiheng@huawei.com> wrote:
>
> The mchp_sparx5_probe() won't destroy workqueue created by
> create_singlethread_workqueue() in sparx5_start() when later
> inits failed. Add destroy_workqueue in the cleanup_ports case,
> also add it in mchp_sparx5_remove()
>
> Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
> ---
> drivers/net/ethernet/microchip/sparx5/sparx5_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
> index eeac04b84638..b6bbb3c9bd7a 100644
> --- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
> +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
> @@ -887,6 +887,8 @@ static int mchp_sparx5_probe(struct platform_device *pdev)
>
> cleanup_ports:
> sparx5_cleanup_ports(sparx5);
> + if (sparx5->mact_queue)
> + destroy_workqueue(sparx5->mact_queue);

Would be better if you destroy inside sparx5_start() before returning failure.

> cleanup_config:
> kfree(configs);
> cleanup_pnode:
> @@ -911,6 +913,7 @@ static int mchp_sparx5_remove(struct platform_device *pdev)
> sparx5_cleanup_ports(sparx5);
> /* Unregister netdevs */
> sparx5_unregister_notifier_blocks(sparx5);
> + destroy_workqueue(sparx5->mact_queue);
>
> return 0;
> }
> --
> 2.32.0
>
[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2022-12-02 09:06    [W:0.069 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site