lkml.org 
[lkml]   [2022]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: [PATCH v1] iavfs/iavf_main: actually log ->src mask when talking about it
From
On 12/16/2022 1:13 AM, Daniil Tatianin wrote:

A couple of nits.

For the title, s/iavfs/iavf

> This fixes a copy-paste issue where dev_err would log the dst mask even
> though it is clearly talking about src.
>
> Found by Linux Verification Center (linuxtesting.org) with the SVACE
> static analysis tool.
>
> Fixes: 0075fa0fadd0a ("i40evf: Add support to apply cloud filters")

This should just be 12 chars:

WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1>
("<title line>")' - ie: 'Fixes: 0075fa0fadd0 ("i40evf: Add support to
apply cloud filters")'

> Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
> ---
> drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index c4e451ef7942..adc02adef83a 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -3850,7 +3850,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
> field_flags |= IAVF_CLOUD_FIELD_IIP;
> } else {
> dev_err(&adapter->pdev->dev, "Bad ip src mask 0x%08x\n",
> - be32_to_cpu(match.mask->dst));
> + be32_to_cpu(match.mask->src));
> return -EINVAL;
> }
> }

\
 
 \ /
  Last update: 2023-03-26 23:15    [W:0.050 / U:1.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site