lkml.org 
[lkml]   [2022]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] tools lib subcmd: Add dependency test to install_headers
On Tue 13 Dec 2022 13:28:21 GMT, Ian Rogers wrote:
> On Mon, Dec 12, 2022 at 12:57 PM Nicolas Schier <nicolas@fjasle.eu> wrote:
> >
> > On Thu, Dec 01, 2022 at 08:57:41PM -0800 Ian Rogers wrote:
> > > Compute the headers to be installed from their source headers and make
> > > each have its own build target to install it. Using dependencies
> > > avoids headers being reinstalled and getting a new timestamp which
> > > then causes files that depend on the header to be rebuilt.
> > >
> > > Signed-off-by: Ian Rogers <irogers@google.com>
> > > ---
> > > tools/lib/subcmd/Makefile | 23 +++++++++++++----------
> > > 1 file changed, 13 insertions(+), 10 deletions(-)
> > >
> > > diff --git a/tools/lib/subcmd/Makefile b/tools/lib/subcmd/Makefile
> > > index 9a316d8b89df..b87213263a5e 100644
> > > --- a/tools/lib/subcmd/Makefile
> > > +++ b/tools/lib/subcmd/Makefile
> > > @@ -89,10 +89,10 @@ define do_install_mkdir
> > > endef
> > >
> > > define do_install
> > > - if [ ! -d '$(DESTDIR_SQ)$2' ]; then \
> > > - $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$2'; \
> > > + if [ ! -d '$2' ]; then \
> > > + $(INSTALL) -d -m 755 '$2'; \
> > > fi; \
> > > - $(INSTALL) $1 $(if $3,-m $3,) '$(DESTDIR_SQ)$2'
> > > + $(INSTALL) $1 $(if $3,-m $3,) '$2'
> >
> > What about using '$(INSTALL) -D ...' instead of the if-mkdir-block above?
> > (E.g. as in tools/debugging/Makefile.)
> >
> > Kind regards,
> > Nicolas
>
> Thanks Nicolas, the reason was to keep the code consistent. That's not
> to say this is the best approach. For example, here is the same thing
> for tools/lib/api:
> https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/lib/api/Makefile?h=perf/core&id=f43368371888694a2eceaaad8f5e9775c092009a#n84
>
> If you'd like to improve this in all the versions and send patches I'd
> be happy to take a look.
>
> Thanks,
> Ian

Ian, while watching at tools/lib/*/Makefile I stumple across the
special single-quote handling (e.g. 'DESTDIR_SQ') several times.

Top-level Makefile and kbuild are not designed to work with file or
directory names containing spaces. Do you know whether this is needed
for the installation rules in tools/lib/? I'd like to remove support
for path names with spaces for a increasing simplicity and consistency.

Kind regards,
Nicolas
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-12-19 16:00    [W:0.083 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site