lkml.org 
[lkml]   [2022]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v16 2/3] dt-bindings: edac: nuvoton: Add document for NPCM memory controller
Hi Krzysztof,

Thanks for the review.

> > So this is a 16th version but through this entire year you never Cced
> > the maintainers... You did not send a single version to the memory
> > controller maintainers.
> >
> > I don't know why it is so big problem to use scripts/get_maintainers.pl.
>
> Although maybe the reason for this is that it was being put in edac
> directory... eh...

I should check the CC list for each version anyway. I'm sorry about that.

> > +++ b/Documentation/devicetree/bindings/memory-controllers/nuvoton,npcm-mc.yaml
>
> filename based on compatibles, so nuvoton,npcm-memory-controller.yaml

> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +
>
> No blank lines.

> > + ahb {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
>
> Why do you need this node in the example?

These problems will be addressed in next patch. Thank you.

Regards,
Marvin

\
 
 \ /
  Last update: 2022-12-19 13:19    [W:0.100 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site