lkml.org 
[lkml]   [2022]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v1] usb: core: hub: disable autosuspend for TI TUSB8041
Date
HI Alan,

...

drivers/usb/core/hub.c index
> > 77e73fc8d673..b64be35e203f 100644
> > --- a/drivers/usb/core/hub.c
> > +++ b/drivers/usb/core/hub.c
> > @@ -44,6 +44,10 @@
> > #define USB_PRODUCT_USB5534B 0x5534
> > #define USB_VENDOR_CYPRESS 0x04b4
> > #define USB_PRODUCT_CY7C65632 0x6570
> > +#define USB_VENDOR_TEXAS_INSTRUMENTS 0x0451
> > +#define USB_PRODUCT_TUSB8041_USB3 0x8140
> > +#define USB_PRODUCT_TUSB8041_USB2 \
> > + (USB_PRODUCT_TUSB8041_USB3 |
> ((USB_PRODUCT_TUSB8041_USB3 & 0x00FF) ^
> > +0x02))
>
> Argh. Just put the actual hex number here -- people don't want to do
> calculations like this in their head when they are reading code. (Not to
> mention that the number would occupy only six characters of source text
> whereas your calculation occupies a lot more.)
>
> Otherwise fine.

Ok, I'll put the actual hex number instead of the formula.
Thanks for your suggestion!

>
> Alan Stern
>

Best regards,
Flavio

\
 
 \ /
  Last update: 2022-12-19 10:50    [W:1.019 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site