lkml.org 
[lkml]   [2022]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] thermal: qcom-spmi-adc5: Suppress probe-deferral error message


On Fri, Dec 16 2022 at 08:09:45 PM +01:00:00, Marijn Suijten
<marijn.suijten@somainline.org> wrote:
> Much like 807efb7102e8 ("thermal: qcom-spmi-adc-tm5: suppress
> probe-deferral error message") the ADC5 driver also spams a similar
> probe-deferral error on startup when a channel is not yet available:
>
> [ 0.343136] qcom-spmi-adc-tm5 1c40000.spmi:pmic@0:adc-tm@3500:
> get dt data failed: -517
>
> Suppress it by using dev_err_probe instead, which also takes care of
> storing the message as reason for deferring.
>
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> drivers/iio/adc/qcom-spmi-adc5.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/qcom-spmi-adc5.c
> b/drivers/iio/adc/qcom-spmi-adc5.c
> index 821fee60a765..69cc36004b5a 100644
> --- a/drivers/iio/adc/qcom-spmi-adc5.c
> +++ b/drivers/iio/adc/qcom-spmi-adc5.c
> @@ -894,10 +894,8 @@ static int adc5_probe(struct platform_device
> *pdev)
> mutex_init(&adc->lock);
>
> ret = adc5_get_fw_data(adc);
> - if (ret) {
> - dev_err(dev, "adc get dt data failed\n");
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(dev, ret, "adc get dt data failed\n");
>
Reviewed-by: Martin Botka <martin.botka@somainline.org>

-Martin
> irq_eoc = platform_get_irq(pdev, 0);
> if (irq_eoc < 0) {
> --
> 2.39.0
>


\
 
 \ /
  Last update: 2022-12-18 12:14    [W:0.221 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site